Pass parameters to ngrok #112
Conversation
This makes it possible to add custom parameters to ngrok. For example: --region=eu -subdomain=YOUR_SUBDOMAIN Some features, like -subdomain, are only available with the paid version of Ngrok.
Added option to pass custom parameters to ngrok
|
This is great. Should be merged. Have paid version of Ngrok and I was trying to get the sub-domain working! 👍 |
|
Looks good, thanks! |
|
@irazasyed You'll be pleased now :) |
|
@renedekat Yep! Thank you :) |
|
@adamwathan Got any estimate on when v1.1.23 will be released? Would be nice to have this feature 😄 |
|
I would recommend just running master for now. There's a weird bug in
|
|
Just wanted to change the region and stumbled across this, done. Thanks a lot 👍 |
This PR allows passing a specific domain name to `valet share` in order to have the app be served for that domain. Now how it works is this: - (NEW) if a domain name is passed, it checks whether it matches a link (which would be required for multiple domains served by same app project), and uses that - if a domain name is NOT passed, it looks up any links for current directory, and uses the first found link - else falls back to current project foldername It also still allows passing through custom ngrok parameters if desired (ref: laravel#112), as either the 2nd parameter (no domain name passed) or (NEW) 3rd parameter Fixes laravel#537
This PR allows passing a specific domain name to `valet share` in order to have the app be served for that domain. Now how it works is this: - (NEW) if a domain name is passed, it checks whether it matches a link (which would be required for multiple domains served by same app project), and uses that - if a domain name is NOT passed, it looks up any links for current directory, and uses the first found link - else falls back to current project foldername It also still allows passing through custom ngrok parameters if desired (ref: laravel#112), as either the 2nd parameter (no domain name passed) or (NEW) 3rd parameter Fixes laravel#537
6 participants
This patch enables passing custom parameters like --region or -subdomain.
valet share --region=eu -subdomain=my_custom_domain
If you have a paid version of Ngrok the subdomain param is available, which is very handy when working with customers. Share the link once, instead of sharing a new random link every time you want your client to look at your progress.